Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tests] Add test for Grid with custom repository method #624

Open
wants to merge 1 commit into
base: poc-new-resource-metadata
Choose a base branch
from
Open

[Tests] Add test for Grid with custom repository method #624

wants to merge 1 commit into from

Conversation

loic425
Copy link
Member

@loic425 loic425 commented Mar 6, 2023 •
edited
Loading

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Related tickets Fixes #626
License MIT

@loic425 loic425 requested a review from a team as a code owner March 6, 2023 11:05
@loic425 loic425 force-pushed the feature/grid-with-custom-repository-method branch from 0a31845 to b8d8c6c Compare March 6, 2023 13:24
@loic425 loic425 changed the title Grid with custom repository method [Tests] Add test for Grid with custom repository method Mar 6, 2023
@loic425 loic425 force-pushed the feature/grid-with-custom-repository-method branch from b8d8c6c to 744c1e8 Compare March 13, 2023 15:28
@lchrusciel lchrusciel added the Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). label Mar 17, 2023
lchrusciel
lchrusciel reviewed Mar 17, 2023
View reviewed changes
src/Bundle/test/src/Repository/BookRepository.php
Comment on lines +31 to +37
public function createListQueryBuilder(): QueryBuilder
{
$queryBuilder = $this->createQueryBuilder('o');
$queryBuilder->andWhere($queryBuilder->expr()->isNotNull('o.archivedAt'));

return $queryBuilder;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you add this code?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The goal of this PR is to test if the grid configuration is applied (such as a repository method defined on the grid)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, but where is it used?

@loic425 loic425 force-pushed the feature/grid-with-custom-repository-method branch from 744c1e8 to eebcb64 Compare March 17, 2023 11:29
@loic425 loic425 force-pushed the poc-new-resource-metadata branch 2 times, most recently from b5a7698 to 5ad1d7d Compare June 20, 2023 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lchrusciel lchrusciel lchrusciel left review comments

Assignees
No one assigned
Labels
Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.).
Projects
Resource & Grid new architecture
Status: 🏗 In Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@loic425 @lchrusciel